I remember well the Firecracker Dance from Holiday Inn, and I really appreciated the dance you speak of in Royal Wedding, much better than the more famous turning room scene. I haven't seen Blue Skies yet, so maybe it's my turn.
I've heard both good and bad about this film, and I have to admit that both the promoters and the critics are correct: this is a great/terrible film. The musical is great: over-the-top dancing, songs by Alan Menkin, a rousing libretto, wow, there is so much to love. On the other hand, Christian Bale.
Perhaps I'll call it the "LaLaLand Syndrome", where you put in all the work to make a top-notch musical and then rest all of that work on a mediocre song-and-dance performer. Look, folks, when I go to a musical, I want to be wowed by the singing and dancing. The jokes can be corny, the acting second-rate, the plot threadbare, but I need it to work when the singing is happening. In a musical, if the moment I'm taken out of the movie is during the music scenes, that's the wrong place. And if the lead performer is the primary cause of my distraction, then you chose the wrong lead. Look, I love Clint Eastwood. But I come to watch him snarl, not sing. I never needed to see Ryan Gosling dance, except perhaps in a candid drunken nightclub jig. I know that Disney could get great singers and dancers for Newsies, because they did. And then put them behind someone who couldn't keep up. I know the reasons. Bale is charismatic and "feels" like a good leader. But the real leader of the historic strike was Kid Blink, placed so far behind this pack of handsome leads that he only got a couple quips in the film. So they made up a leader, gave him the handsomest face they could find and decided as a singer and dancer he was "good enough." Well, not for me. /rantover.
Still, there is much worthy to see in this film. Great sets, Duvall acting silly, wonderful dancing (if you look past Bale), and just an overall good time. But honestly, it is such a good musical that I think I'll watch the Broadway production to see what it should really be like.